Repository navigation
MNT: Fix Ruff rule PLR0911 violation in astropy/convolution - #17823
Merged
Merged
Conversation
VarunNikam22
requested review from
WilliamJamieson,
larrybradley and
nstarman
as code owners
February 26, 2025 08:44
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
reviewed
Feb 26, 2025
Member
There was a problem hiding this comment.
I wonder if this can benefit from case statement but that is unrelated thought...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures compliance of
astropy/convolutionto Ruff rule PLR0911 (too-many-return-statements).Affects
astropy/convolution/utils.pywhere the methoddiscretize_modelreturns a discretized analytical model. Model chosen based on arguments is evaluated, stored in a variable and is returned once in the end.Fixes #14818 partially