Skip to content

MNT: Fix Ruff rule PLR0911 violation in astropy/convolution - #17823

Merged
pllim merged 1 commit into
astropy:mainfrom
VarunNikam22:fix/ruff_PLR0911_convolution
Feb 26, 2025
Merged

pllim merged 1 commit into
astropy:mainfrom
VarunNikam22:fix/ruff_PLR0911_convolution

Conversation

@VarunNikam22

Copy link
Copy Markdown
Contributor

Description

This PR ensures compliance of astropy/convolution to Ruff rule PLR0911 (too-many-return-statements).

Affects astropy/convolution/utils.py where the method discretize_model returns a discretized analytical model. Model chosen based on arguments is evaluated, stored in a variable and is returned once in the end.

Fixes #14818 partially

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim added this to the v7.1.0 milestone Feb 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this can benefit from case statement but that is unrelated thought...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17825 👀

@pllim
pllim merged commit 5874364 into astropy:main Feb 26, 2025
@VarunNikam22
VarunNikam22 deleted the fix/ruff_PLR0911_convolution branch May 22, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure compliance with more Ruff rules

4 participants