Repository navigation
fix ruff rule c408 violations in all remaining subpackages - #17798
Merged
Merged
Conversation
VarunNikam22
requested review from
WilliamJamieson,
astrofrog and
nstarman
as code owners
February 20, 2025 07:09
github-actions
Bot
added
testing
nddata
logging
wcs.wcsapi
uncertainty
dev-automation
labels
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
neutrinoceros
requested changes
Feb 20, 2025
neutrinoceros
left a comment
neutrinoceros
left a comment
Contributor
There was a problem hiding this comment.
Thanks ! If I understand the discussion over at #14818 correctly, this shouldn't be controversial. There's one mistake to fix though.
| from IPython import get_ipython | ||
|
|
||
| get_ipython().set_custom_exc(tuple(), None) | ||
| get_ipython().set_custom_exc({}, None) |
Contributor
There was a problem hiding this comment.
this isn't equivalent, it should be ()
Contributor
Author
There was a problem hiding this comment.
Ah, sorry for the typo. Corrected it in the next commit.
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address remaining violations of the ruff rule C408 across all subpackages byrefactoring dict() and tuple() calls by literals.
This PR affects the following subpackages:
Fixes part of #14818