Repository navigation
Backport PR #17751 on branch main (Backport PR #17747 on branch v7.0.x (Ensure doctests do not have side effects)) - #17757
Conversation
… (Ensure doctests do not have side effects)
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Haha, it works! 😆 |
mhvk
left a comment
There was a problem hiding this comment.
I don't quite like that I don't understand why this was needed on 7.0.x, but the double test seems to pass on main.
But I now checked and on current main, I get a failure if I do
pytest --keep-duplicates docs/table/mixin_columns.rst docs/table/mixin_columns.rst
So, in the usual duplicate run, perhaps something gets reset in between that avoids the failure, but that still suggests it is good to add the test cleanup here.
I still don't grok why it is reset sometimes... but glad you able to patch it. Thank you very much! |
|
Have we considered the possibility that running double tests with parallelization introduces some non-determinism to the build ? |
|
It is very possible. At the smallest level, even if we clean up with |
Backport PR #17751: Backport PR #17747 on branch v7.0.x (Ensure doctests do not have side effects)