Skip to content

BUG: avoid test pollution in astropy.modeling - #17752

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:modeling/test/avoid_test_pollution
Feb 10, 2025
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:modeling/test/avoid_test_pollution

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Partially address #17745

The problem here is that these tests mutate the objects they are parametrized with (which I assume is expected). The solution is to only create the objects within the test itself so they are not reused if the test runs more than once.

reprod (requires scipy)

pytest astropy/modeling/tests/test_input.py astropy/modeling/tests/test_input.py -k test_call_keyword_args --keep-duplicates
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title BUG: avoid test pollution in astropy.modeling BUG: avoid test pollution in astropy.modeling Feb 10, 2025

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the problem was that the input argument got modified in the function, right? If so, this looks like a nice solution.

@neutrinoceros
neutrinoceros marked this pull request as ready for review February 10, 2025 14:37
@neutrinoceros
neutrinoceros requested a review from a team as a code owner February 10, 2025 14:37
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

I guess the problem was that the input argument got modified in the function, right?

correct !

@pllim
pllim merged commit b61bb1f into astropy:main Feb 10, 2025
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 10, 2025
@neutrinoceros
neutrinoceros deleted the modeling/test/avoid_test_pollution branch February 10, 2025 15:59
pllim added a commit that referenced this pull request Feb 10, 2025
…752-on-v7.0.x

Backport PR #17752 on branch v7.0.x (BUG: avoid test pollution in `astropy.modeling`)
@pllim pllim mentioned this pull request Feb 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants