Repository navigation
Backport PR #17747 on branch v7.0.x (Ensure doctests do not have side effects) - #17751
Merged
pllim merged 2 commits intoFeb 10, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
@mhvk any idea why this doctest fails in backport but not on |
Contributor
|
I think we'd need to backport a previous fix to the registry or so, since the |
Member
|
Re: forward-port -- Hmm I dunno if the universe is going to explode or not if we forward port a backport, but can try after merge? |
This comment was marked as duplicate.
This comment was marked as duplicate.
Member
|
Let's see if anything explodes... @meeseeksdev backport to main |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 10, 2025
… (Ensure doctests do not have side effects)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #17747: Ensure doctests do not have side effects