MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22)#17723
Merged
pllim merged 1 commit intoastropy:mainfrom Feb 4, 2025
Merged
MNT: upgrade sp-repo-review (v2024.08.19 -> v2025.01.22)#17723pllim merged 1 commit intoastropy:mainfrom
v2024.08.19 -> v2025.01.22)#17723pllim merged 1 commit intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
v2024.08.19 -> v2025.01.22)
Member
|
Yes for now, but can you put this in |
Contributor
Author
|
Did you intend to post this reply somewhere else or am I missing something ? This is not about ruff (I think ?). |
Member
|
You're right. I was thinking about our temporary ignores. Because there's slow discussion about not packaging the tests inside of astropy, per recommendation by Scientific Python |
Contributor
Author
|
Should I link an issue or PR in particular in a comment ? |
Member
|
Nah. G2G. |
nstarman
approved these changes
Feb 4, 2025
pllim
approved these changes
Feb 4, 2025
Member
pllim
left a comment
There was a problem hiding this comment.
Uncontroversial enough. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #17719