MNT: upgrade zizmor (v1.0.0 -> v1.3.0)#17721
Merged
pllim merged 1 commit intoastropy:mainfrom Feb 4, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
v1.0.0 -> v1.3.0)
nstarman
approved these changes
Feb 4, 2025
Member
|
LGTM but wait for the security team. |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@neutrinoceros are you able to help with manual backport? If not, I can do it. Let me know. Thanks! 🙏 |
Contributor
Author
|
Out of office hours for today, but happy to do it in the morning ! |
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Feb 4, 2025
…r_1.3.0 MNT: upgrade zizmor (`v1.0.0` -> `v1.3.0`) (cherry picked from commit d1421cd)
1 task
Member
|
Ah, don't worry about it then. I opened #17724 . Thanks! |
pllim
added a commit
that referenced
this pull request
Feb 4, 2025
Backport PR #17721 on branch v7.0.x (MNT: upgrade zizmor (v1.0.0 -> v1.3.0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a manual upgrade for zizmor, previously attempted automatically in #17710
The one new error flagged is explained in zizmor's doc. I've attempted to set explicit permissions in all places reported by zizmor 1.3.0, but I expect a couple iterations might be needed to get this right.
EDIT: Also close #14072