Skip to content

Comments

[pre-commit.ci] pre-commit autoupdate#17710

Closed
pre-commit-ci[bot] wants to merge 2 commits intomainfrom
pre-commit-ci-update-config
Closed

[pre-commit.ci] pre-commit autoupdate#17710
pre-commit-ci[bot] wants to merge 2 commits intomainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 3, 2025

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
a56139f 
updates:
- [github.com/woodruffw/zizmor-pre-commit: v1.0.0 → v1.3.0](zizmorcore/zizmor-pre-commit@v1.0.0...v1.3.0)
- [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1)
- [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.4](astral-sh/ruff-pre-commit@v0.8.6...v0.9.4)
- [github.com/scientific-python/cookie: 2024.08.19 → 2025.01.22](scientific-python/cookie@2024.08.19...2025.01.22)
@github-actions github-actions bot added testing skip-changelog-checks Tells bot to skip changlog checks dev-automation labels Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v7.1.0 milestone Feb 3, 2025
pllim
pllim reviewed Feb 3, 2025
View reviewed changes
astropy/io/fits/column.py
other = [other]
_other = [_get_index(self.names, key) for key in other]
indx = list(range(len(self)))
index = list(range(len(self)))
Copy link
Member

@pllim pllim Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary?

Copy link
Member

@nstarman nstarman Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't overwrite other variables, so 🤷. Even more explicit.

@pllim
Copy link
Member

pllim commented Feb 3, 2025 •
edited
Loading

Not sure what's up with oldest deps, I restarted the same job on main to double check. (Update: not related)

Huh, precommit update broke precommit check...

@pllim
Copy link
Member

pllim commented Feb 3, 2025

I don't like the state of this auto update. Perhaps it is cleaner if someone manually do this. Thanks!

@pllim pllim closed this Feb 3, 2025
@pllim pllim deleted the pre-commit-ci-update-config branch February 3, 2025 20:07
This was referenced Feb 4, 2025
Closed
Merged
Merged
@neutrinoceros
Copy link
Contributor

neutrinoceros commented Feb 4, 2025

Perhaps it is cleaner if someone manually do this.

done x4:

@eerovaher eerovaher mentioned this pull request Feb 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner

@nstarman nstarman Awaiting requested review from nstarman nstarman is a code owner

@astrofrog astrofrog Awaiting requested review from astrofrog astrofrog is a code owner

@mcara mcara Awaiting requested review from mcara mcara is a code owner

@larrybradley larrybradley Awaiting requested review from larrybradley larrybradley is a code owner

@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner

@saimn saimn Awaiting requested review from saimn saimn is a code owner

@dhomeier dhomeier Awaiting requested review from dhomeier dhomeier is a code owner

Assignees

No one assigned

Labels

dev-automation skip-changelog-checks Tells bot to skip changlog checks testing

Projects

None yet

Milestone

v7.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @neutrinoceros @nstarman