STY: semi-manual fix for FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)#17619
Closed
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Closed
STY: semi-manual fix for FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)#17619neutrinoceros wants to merge 1 commit intoastropy:mainfrom
FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)#17619neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Conversation
neutrinoceros
changed the title
FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
eerovaher
reviewed
Jan 9, 2025
Comment on lines
258
to
259
| tform = compressed_coldefs[column_name].format | ||
| if tform.startswith("1"): | ||
| tform = tform[1:] | ||
| tform = tform.removeprefix("1") |
Member
There was a problem hiding this comment.
At the very least
- tform = compressed_coldefs[column_name].format
- if tform.startswith("1"):
- tform = tform[1:]
+ tform = compressed_coldefs[column_name].format.removeprefix("1")That being said, it's not clear to me why this function prefers to write out a long if-elif-elif chain instead of doing a simple dictionary lookup.
Member
There was a problem hiding this comment.
Looks like it was introduced in #14430 , performance work by @Cadair and @astrofrog
Member
There was a problem hiding this comment.
I haven't looked at this in detail, but if this is meant to be performance-critical then it is quite surprising to see indexing in all of the elif statements.
neutrinoceros
force-pushed
the
io.fits/sty/FURB188
branch
from
e9b9583 to
b9ebc21
Compare
neutrinoceros
changed the title
FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)FURB188 (slice-to-remove-prefix-or-suffix) (io.fits)
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref #17615
doc
FURB188