Skip to content

Comments

STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table)#17617

Merged
taldcroft merged 1 commit intoastropy:mainfrom
neutrinoceros:table/sty/FURB188
Jan 10, 2025
Merged

STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table)#17617
taldcroft merged 1 commit intoastropy:mainfrom
neutrinoceros:table/sty/FURB188

Conversation

@neutrinoceros
Copy link
Contributor

Description

ref #17615
doc FURB188

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros changed the title STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table) STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table) Jan 9, 2025
@neutrinoceros neutrinoceros changed the title STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table) STY: autofix for FURB188 (slice-to-remove-prefix-or-suffix) (table) Jan 9, 2025
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@taldcroft taldcroft merged commit 77bb87d into astropy:main Jan 10, 2025
24 of 27 checks passed
@neutrinoceros neutrinoceros deleted the table/sty/FURB188 branch January 10, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants