Repository navigation
add public modules to use direct import first stage like 'import astr… - #17587
celik-muhammed wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].
|
Hi ! Could you explain your motivation for this change ? Unfortunately, exposing more public API paths comes with a very high maintenance cost so I must say it's unlikely we'd accept it. Maybe we could offer a better solution if you told us what the problem was ? |
|
Thanks for explanation, |
pllim
left a comment
There was a problem hiding this comment.
Hello. Unfortunately I do not understand what this is actually trying to solve. Even without this patch, import astropy.stats as st already works.
|
Yes, it works without this patch; I checked it. In my specific scenario, where the internet is not available for some time, import astropy The stats module is not present, so I assume it was added in a later version. I want to emphasize that when working offline, having the available submodules listed in the result of the dir function or including them in the docstring would be much more useful. |
|
I see. Thank you for bringing this to our attention, I agree that the top level namespace could be cleaned up. I have opened #17589 as a follow-up issue for discussion and we can always revisit this PR in the future once consensus is reached. Thanks again! |
… 'import astropy.stats as st'
Description
This pull request is to address ...
Fixes #