Skip to content

TST: avoid NameErrors in a couple tests that couldn't be run in isolation - #17559

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.registry/tst/fix_unbound_local_error
Dec 18, 2024
Merged

TST: avoid NameErrors in a couple tests that couldn't be run in isolation#17559
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.registry/tst/fix_unbound_local_error

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #17558

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.0.1 milestone Dec 18, 2024
@neutrinoceros neutrinoceros added Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v7.0.x labels Dec 18, 2024
@github-actions

github-actions Bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title TST: avoid NameErrors in a couple tests that couldn't be run in isolation TST: avoid NameErrors in a couple tests that couldn't be run in isolation Dec 18, 2024
@neutrinoceros
neutrinoceros marked this pull request as ready for review December 18, 2024 13:10
@neutrinoceros neutrinoceros mentioned this pull request Dec 18, 2024
Closed
1 task
nstarman
nstarman reviewed Dec 18, 2024
View reviewed changes
Comment thread astropy/io/registry/tests/test_registries.py
assert docs[-1][iread : iread + 3] != "Yes"
# now test it's updated
docs = EmptyData.read.__doc__.split("\n")
ihd = [i for i, s in enumerate(docs) if ("Format" in s)][0]

@nstarman nstarman Dec 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a slightly larger factor is called for here. The above test block could be dedented from the context and then some of the index creators can be moved out of the conditional block using the solution here.

@neutrinoceros neutrinoceros Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above test block could be dedented from the context

I'm not sure that's the case; without looking to deeply into how this context works exactly, it seems to me that the only difference between line 346 and line 355 is that the former happens within the context, while the latter doesn't.

@nstarman nstarman Dec 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. you're right. It happens at context exit.

@pllim

pllim commented Dec 18, 2024

Copy link
Copy Markdown
Member

I see that you applied "affects-dev" label but if it only affects development version, why the backport?

@pllim pllim added testing and removed Affects-dev PRs and issues that do not impact an existing Astropy release labels Dec 18, 2024
@pllim
pllim merged commit 93b6f55 into astropy:main Dec 18, 2024
@pllim

pllim commented Dec 18, 2024

Copy link
Copy Markdown
Member

Anyways, I will remove that label. Thanks, all!

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 18, 2024
@pllim @meeseeksmachine
Backport PR astropy#17559: TST: avoid NameErrors in a couple tests …
1ec1751 
…that couldn't be run in isolation
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 18, 2024
Merged
pllim added a commit that referenced this pull request Dec 18, 2024
@pllim
Merge pull request #17561 from meeseeksmachine/auto-backport-of-pr-17…
8b1e116 
…559-on-v7.0.x

Backport PR #17559 on branch v7.0.x (TST: avoid `NameError`s in a couple tests that couldn't be run in isolation)
@neutrinoceros

neutrinoceros commented Dec 19, 2024

Copy link
Copy Markdown
Contributor Author

I guess I had a slightly wrong interpretation of that label: I thought it meant "doesn't affect end users". Anyway, thanks for fixing my mistake !

@neutrinoceros
neutrinoceros deleted the io.registry/tst/fix_unbound_local_error branch December 19, 2024 06:26
@pllim

pllim commented Dec 19, 2024

Copy link
Copy Markdown
Member

No worries. It was added years ago by embray for change log check in the sense that we do not need change log if a bug has not been released yet. Now I think it is mostly informational.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstarman nstarman nstarman approved these changes

Assignees

No one assigned

Labels

Bug io.registry no-changelog-entry-needed testing

Projects

None yet

Milestone

v7.0.1

Development

Successfully merging this pull request may close these issues.

TST: two tests from astropy/io/registry/tests/test_registries.py that cannot be run in isolation

3 participants

@neutrinoceros @pllim @nstarman