Repository navigation
BUG: ensure that docstrings for read/write public methods are always available for inspection (io.registry) (⏰ wait for #17559) - #17557
Closed
neutrinoceros wants to merge 2 commits into
Conversation
…available for inspection (UnifiedReadWrite)
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
1 task
io.registry)
Contributor
Author
|
looks like I made a mistake here. However, #17558 makes this extra difficult to debug, so I'm going to prioritize that issue before I come back here. |
io.registry)io.registry) (⏰ wait for #17559)
neutrinoceros
force-pushed
the
io.registry/bug/compat_optimized_mode
branch
from
December 18, 2024 13:46
8b77fa6 to
2688639
Compare
Contributor
Author
|
This now includes the patch from #17559 for convenience, but I still expect a merge conflict so I'll giving the other PR priority as it's also a backport candidate. |
neutrinoceros
force-pushed
the
io.registry/bug/compat_optimized_mode
branch
from
December 18, 2024 13:48
2688639 to
d336960
Compare
1 task
Contributor
Author
|
closing this following discussion over at #17555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref #17472
this one is paired with a test refactor to avoid direct accesses to
__doc__where possible.