Skip to content

TST: fix incorrect branching on numpy version - #17523

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:units/compat/numpy_2_2_matvec_vecmat
Dec 9, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:units/compat/numpy_2_2_matvec_vecmat

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

A quick follow up to #17464 after np.matvec and np.vecmat were actually released yesterday under NumPy 2.2.0
example logs

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.0.1 milestone Dec 9, 2024
@neutrinoceros neutrinoceros added Bug 🔥 Critical Affects-dev PRs and issues that do not impact an existing Astropy release backport-v7.0.x no-changelog-entry-needed labels Dec 9, 2024
@github-actions github-actions Bot added the units label Dec 9, 2024
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a 7.0.x release soon then?

Does this need a change log?

@pllim
pllim requested a review from mhvk December 9, 2024 16:56
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

@pllim sorry but could you revert your commit please ? it's still useful to have dev versions as lower limits when doing bisections against numpy.
And to answer your question this change is test-only, not user visible, so I don't think it warrants a prompt release or a change log.

@neutrinoceros
neutrinoceros force-pushed the units/compat/numpy_2_2_matvec_vecmat branch from 3b199b1 to 1c96d9a Compare December 9, 2024 17:20
@pllim

pllim commented Dec 9, 2024

Copy link
Copy Markdown
Member

Ooops sorry, reverted.

In the past, we have always removed "dev" from the check once stable is released...

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Well, it's not broken...

@pllim

pllim commented Dec 9, 2024

Copy link
Copy Markdown
Member

Well, let's fix the immediate fire first. Thanks!

@mhvk

mhvk commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Belated thanks, @neutrinoceros!

pllim added a commit that referenced this pull request Dec 9, 2024
…523-on-v7.0.x

Backport PR #17523 on branch v7.0.x (TST: fix incorrect branching on numpy version)
@neutrinoceros
neutrinoceros deleted the units/compat/numpy_2_2_matvec_vecmat branch December 9, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug 🔥 Critical no-changelog-entry-needed units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants