Skip to content

BUG: fix a crash in Table.show_in_browser due to an internal type inconsistency - #17513

Merged
hamogu merged 1 commit into
astropy:mainfrom
neutrinoceros:table/bug/17512/fix_show_in_browser_internal_type_consistency
Dec 6, 2024
Merged

hamogu merged 1 commit into
astropy:mainfrom
neutrinoceros:table/bug/17512/fix_show_in_browser_internal_type_consistency

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #16939
Fixes #17512

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot added the table label Dec 6, 2024
@github-actions

github-actions Bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the table/bug/17512/fix_show_in_browser_internal_type_consistency branch from 1ee9140 to 65d3eaf Compare December 6, 2024 16:38
@neutrinoceros
neutrinoceros marked this pull request as ready for review December 6, 2024 16:40
@neutrinoceros neutrinoceros changed the title BUG: fix a crash in Table.show_in_browser due to an internal type inconsistency BUG: fix a crash in Table.show_in_browser due to an internal type inconsistency Dec 6, 2024
@hamogu
hamogu merged commit 62be81e into astropy:main Dec 6, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 6, 2024
@neutrinoceros
neutrinoceros deleted the table/bug/17512/fix_show_in_browser_internal_type_consistency branch December 6, 2024 21:01
neutrinoceros added a commit that referenced this pull request Dec 7, 2024
…513-on-v7.0.x

Backport PR #17513 on branch v7.0.x (BUG: fix a crash in `Table.show_in_browser` due to an internal type inconsistency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

table show_in_browser() broken

2 participants