Skip to content

cosmo: refactor separate rhocrit mixin - #17500

Merged
nstarman merged 3 commits into
astropy:mainfrom
nstarman:cosmo/api/sep-rhocrit
Dec 5, 2024
Merged

nstarman merged 3 commits into
astropy:mainfrom
nstarman:cosmo/api/sep-rhocrit

Conversation

@nstarman

@nstarman nstarman commented Dec 4, 2024 •

Copy link
Copy Markdown
Member

Part of #17150
In draft mode until #17153 is merged.

This PR also simplifies the calculation for critical_density0 since the value is cached and performance is no longer critical.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@nstarman nstarman added this to the v7.1.0 milestone Dec 4, 2024
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman mentioned this pull request Dec 4, 2024
12 of 22 tasks
@nstarman
nstarman force-pushed the cosmo/api/sep-rhocrit branch from 3915d40 to 08c059d Compare December 5, 2024 18:28
@nstarman
nstarman marked this pull request as ready for review December 5, 2024 18:30
@nstarman
nstarman requested a review from a team as a code owner December 5, 2024 18:30
critical_density0 is cached, so it’s fine to use the simpler but slower expression.

Signed-off-by: nstarman <[email protected]>
@nstarman
nstarman force-pushed the cosmo/api/sep-rhocrit branch from 08c059d to 03a7921 Compare December 5, 2024 18:42
@nstarman
nstarman force-pushed the cosmo/api/sep-rhocrit branch from 03a7921 to 2d77caa Compare December 5, 2024 19:05
@nstarman
nstarman requested a review from eerovaher December 5, 2024 19:20

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not quite clear of the benefit of splitting the basic methods out into separate classes, but will take your word for it.

That leaves only one question: you state that performance is not critical since values are cached, but that would only be the case if a given cosmology is used multiple times to calculate something. If one is fitting a cosmology and in the process, say, varying H, so that the fits includes creating a new instance every iteration, then performance might still matter.

Though to be honest I doubt it will for the piece that you remove here, so approving.

@nstarman
nstarman merged commit 5e79c04 into astropy:main Dec 5, 2024
@nstarman
nstarman deleted the cosmo/api/sep-rhocrit branch December 5, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants