Skip to content

Fix Ruff rule PT022 violations - #17479

Merged
nstarman merged 1 commit into
astropy:mainfrom
tanvincible:fixpt022
Dec 5, 2024
Merged

nstarman merged 1 commit into
astropy:mainfrom
tanvincible:fixpt022

Conversation

@tanvincible

@tanvincible tanvincible commented Nov 29, 2024 •

Copy link
Copy Markdown
Contributor

Description

This pull request addresses Ruff rule PT022 violations globally.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@nstarman nstarman added this to the v7.1.0 milestone Dec 5, 2024
@nstarman
nstarman merged commit 2d28101 into astropy:main Dec 5, 2024
@nstarman

nstarman commented Dec 5, 2024

Copy link
Copy Markdown
Member

Thanks @TanviPooranmal !

@tanvincible
tanvincible deleted the fixpt022 branch December 5, 2024 18:41
@eerovaher eerovaher mentioned this pull request Dec 5, 2024
3 of 6 tasks
@eerovaher

Copy link
Copy Markdown
Member

It's good that we are enforcing PT022 now, but this shouldn't have closed #14818.

@tanvincible

Copy link
Copy Markdown
Contributor Author

My bad! I mistakenly mentioned fixes in the PR description. Corrected the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants