Skip to content

BUG: fix importing from astropy.config.paths under Python's optimized mode - #17473

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:config/bug/fix_import_optimized_python
Dec 10, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:config/bug/fix_import_optimized_python

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

This fixes the issue I initially noticed and reported in #17472, but it's not sufficient to bring support for Python's optimized mode by itself, so, while backporting wouldn't hurt, it's probably not needed.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the config/bug/fix_import_optimized_python branch from 77d6e32 to 2df2cbd Compare November 29, 2024 09:26
@neutrinoceros
neutrinoceros marked this pull request as ready for review November 29, 2024 09:26

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to look at this carefully to realize there were both cache and config before I could see this was correct. But it seems so!

@pllim
pllim merged commit 44b110b into astropy:main Dec 10, 2024
@neutrinoceros
neutrinoceros deleted the config/bug/fix_import_optimized_python branch December 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants