Repository navigation
BUG: fix importing from astropy.config.paths under Python's optimized mode - #17473
Merged
pllim merged 1 commit intoDec 10, 2024
Merged
Conversation
1 task
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
config/bug/fix_import_optimized_python
branch
from
November 29, 2024 09:26
77d6e32 to
2df2cbd
Compare
neutrinoceros
marked this pull request as ready for review
November 29, 2024 09:26
mhvk
approved these changes
Nov 29, 2024
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Needed to look at this carefully to realize there were both cache and config before I could see this was correct. But it seems so!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue I initially noticed and reported in #17472, but it's not sufficient to bring support for Python's optimized mode by itself, so, while backporting wouldn't hurt, it's probably not needed.