Repository navigation
TST: fixup test from pr-17464 - #17467
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
Author
|
@pllim - would you mind having a quick look at this PR that fixes a very silly oversight? Thanks! (Note: the relevant -devdeps job passed). |
neutrinoceros
approved these changes
Nov 28, 2024
neutrinoceros
left a comment
Contributor
There was a problem hiding this comment.
This is clearly correct, sorry for not catching it myself
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Nov 28, 2024
neutrinoceros
added a commit
that referenced
this pull request
Nov 28, 2024
…467-on-v7.0.x Backport PR #17467 on branch v7.0.x (TST: fixup test from pr-17464)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to address a small problem with a test added in #17464 that I failed to notice, and that was merged because the failure only occurred in with devdeps -- silly me to be in a hurry and think I could just enable auto-merge on a devdeps fix.
Only merge this is devdeps now passes!