Skip to content

TST: fixup test from pr-17464 - #17467

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
mhvk:pr-17464-fixup
Nov 28, 2024
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
mhvk:pr-17464-fixup

Conversation

@mhvk

@mhvk mhvk commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

This pull request is to address a small problem with a test added in #17464 that I failed to notice, and that was merged because the failure only occurred in with devdeps -- silly me to be in a hurry and think I could just enable auto-merge on a devdeps fix.

Only merge this is devdeps now passes!

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk

mhvk commented Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

@pllim - would you mind having a quick look at this PR that fixes a very silly oversight? Thanks! (Note: the relevant -devdeps job passed).

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly correct, sorry for not catching it myself

@neutrinoceros
neutrinoceros merged commit 5d51416 into astropy:main Nov 28, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 28, 2024
neutrinoceros added a commit that referenced this pull request Nov 28, 2024
…467-on-v7.0.x

Backport PR #17467 on branch v7.0.x (TST: fixup test from pr-17464)
@mhvk
mhvk deleted the pr-17464-fixup branch November 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants