Skip to content

setup/version-legacy-packages - #174

Merged
mdboom merged 4 commits into
astropy:masterfrom
mdboom:setup/version-legacy-packages
Mar 22, 2012
Merged

mdboom merged 4 commits into
astropy:masterfrom
mdboom:setup/version-legacy-packages

Conversation

@mdboom

@mdboom mdboom commented Feb 16, 2012

Copy link
Copy Markdown
Contributor

This adds an equivalent version to the legacy package so version checks against the legacy packages work.

I understand this requires manual updating as legacy packages are merged into astropy -- if anyone can think of a better way I'm open to it, but this solves my immediate need for now.

…code that does version checks on the legacy package work.
@embray

embray commented Feb 16, 2012

Copy link
Copy Markdown
Member

+1 that's a good idea.

I have to say, this whole legacy shim apparatus is pretty awesome. I can't wait for the first Astropy release so we can start trying to use it.

One thing I might add to this: In addition to __version__ it might be nice if each package could provide a add_legacy_alias a whole dict of arbitrary variables to include in the generated __init__.py.

For example, PyFITS has an __svn_version__ variable. I don't know that there's any code that relies on it being there, but some users might check it. I could use this a place to record the svn revision each time I do a merge to astropy from pyfits.

…ariables to the __init__.py for the legacy shim. For demonstration purposes, added the SVN revision last merged from PyFITS. PyFITS has a built-in variable called __svn_revision__, so this would support that. Unfortunately, this does nothing to fix the fact that this value will have to be updated manually.
@taldcroft

Copy link
Copy Markdown
Member

I'm guessing I'll want to add asciitable as a legacy package.

@mdboom

mdboom commented Feb 17, 2012

Copy link
Copy Markdown
Contributor Author

This now includes @iguananaut's extension to include arbitrary values in the legacy shim's __init__.py.

@eteq

eteq commented Feb 20, 2012

Copy link
Copy Markdown
Member

Perhaps a short section should be added in the developer documentation to mention how this system works? I can actually imagine this mechanism might be useful for to people who might not be following the development too closely (including e.g. adding legacy shims for old packages to affiliated packages rather than the astropy core).

@eteq

eteq commented Mar 5, 2012

Copy link
Copy Markdown
Member

@mdboom - are you thinking will add the aforementioned documentation section in this pull request, or should I merge this and just add an issue about it to be dealt with later?

@mdboom

mdboom commented Mar 22, 2012

Copy link
Copy Markdown
Contributor Author

Sure, let's go ahead and merge. I had meant to add developer docs, but it's a little tricky -- the usage of this is already documented, so that's the basics covered, at least.

mdboom added a commit that referenced this pull request Mar 22, 2012
@mdboom
mdboom merged commit ad9fd8c into astropy:master Mar 22, 2012
@eteq

eteq commented Mar 22, 2012

Copy link
Copy Markdown
Member

Ok, I'll try to look for a space to put this in the work I'm doing for #162, and afterwards you can fill it in whenever you find the time. Thanks!

keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@mdboom
mdboom deleted the setup/version-legacy-packages branch May 21, 2014 23:56
astrofrog pushed a commit to astrofrog/astropy that referenced this pull request Jun 12, 2019
Slight tweak to ensure that the (possible) C++ filename associated wi…
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Fix last name typo for Ginga maintainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants