Skip to content

Fix creating CompImageHDU from header with bscale/bzero - #17237

Merged
astrofrog merged 1 commit into
astropy:mainfrom
saimn:fits-fix-5999
Oct 25, 2024
Merged

astrofrog merged 1 commit into
astropy:mainfrom
saimn:fits-fix-5999

Conversation

@saimn

@saimn saimn commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Fix #5999

See also discussion in #15474 (comment).

When creating CompImageHDU from a header with BSCALE/BZERO these keywords should be ignored, as done in ImageHDU.

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added this to the v7.0.0 milestone Oct 23, 2024
@saimn
saimn requested a review from astrofrog October 23, 2024 15:46
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

Copy link
Copy Markdown
Contributor

failures look real and weirdly platform dependent. If you need a hand from someone working on macOS let me know ! (I don't know your dev platform)

@saimn

saimn commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Fixed (failure was happening in a slow test).

@pllim pllim added the Bug label Oct 23, 2024
@astrofrog
astrofrog merged commit 96b49c0 into astropy:main Oct 25, 2024
@saimn
saimn deleted the fits-fix-5999 branch October 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fits.CompImageHDU writes unexpected/incorrect BZERO keyword after conversion from unsigned image data

4 participants