BLD/RFC: simplify path type casting in `wcs/setup_package.py` by neutrinoceros · Pull Request #17193 · astropy/astropy

neutrinoceros · 2024-10-16T16:51:32Z

Description

Extracted from and a continuation of #16936, cleaning up path type casting that becomes redundant with extension-helpers 1.2.0
This will require extension-helpers 1.2.0 or newer to become available on exotic archs.

update: Here's a dynamic view of extension-helpers packaging status

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2024-10-16T16:52:00Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2024-10-16T16:52:02Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

mhvk

This looks good to me. Why does this need the extension helpers update, though?

mhvk · 2024-10-16T17:39:36Z

    get_wcslib_cfg(cfg, wcslib_files, wcslib_config_paths)

-    cfg["include_dirs"].append(join(WCSROOT, "include"))
+    cfg["include_dirs"].append(WCSROOT / "include")


Should this have a str(...) too, like the others?

ah, yes. I got things mixed up here, but passing Paths directly to setuptools requires another upgrade that we cannot afford yet because it's not available on exotic archs.
Anyway, thanks for catching this !

Hmm, that leaves me still confused what part actually is solved by upgrading extension helpers.

it should be clearer if you look just at the second commit
8b4fc9f (#17193)

mhvk · 2024-10-16T17:41:54Z

+            if isinstance(header, (str, bytes, os.PathLike)):
                try:
-                    is_path = os.path.exists(header)
+                    is_path = os.path.exists(header)  # noqa: PTH110


Can one not replace with Path(header).exists()?

that would be a comment for #16936, but yes, we could avoid a noqa here

neutrinoceros · 2024-10-17T08:05:11Z

Why does this need the extension helpers update, though?

See #16936 (comment) : extension-helpers 1.2.0 improves native support for Path objects.
This PR shouldn't be reviewed for the time being: only the last commit is relevant.

mhvk · 2024-10-17T12:44:26Z

OK, so then all the str(path) in setup_package can go too?

neutrinoceros · 2024-10-17T13:36:55Z

No. The remaining ones are needed for compatibility with setuptools<72, which we still need to support building on "exotic archs".

github-actions · 2025-03-16T05:41:04Z

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

astrofrog · 2026-09-11T13:40:00Z

@neutrinoceros - would it make sense to try and wrap this up? It should be uncontroversial I imagine?

neutrinoceros · 2026-09-11T13:44:28Z

Oh yes. Thanks for reminding me

neutrinoceros · 2026-09-11T16:02:37Z

One unrelated failure on extra CI. Addressed in #20373

neutrinoceros added this to the v7.1.0 milestone Oct 16, 2024

neutrinoceros added Extra CI Run cron CI as part of PR no-changelog-entry-needed labels Oct 16, 2024

github-actions Bot added testing wcs installation wcs.wcsapi dev-automation labels Oct 16, 2024

neutrinoceros mentioned this pull request Oct 16, 2024

MNT: Run PTH flake test in prep for supporting pathlib (wcs) #16936

Closed

1 task

mhvk reviewed Oct 16, 2024

View reviewed changes

neutrinoceros changed the title ~~BLD: require extension-helpers 1.2.0 and simplify path type casting~~ BLD: require extension-helpers 1.2.0 and simplify path type casting (⏰ wait for #16936) Oct 17, 2024

github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Mar 16, 2025

neutrinoceros added keep-open and removed Close? Tell stale bot that this issue/PR is stale labels Mar 17, 2025

astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025

astrofrog modified the milestones: v7.2.0, v8.0.0 Nov 3, 2025

astrofrog modified the milestones: v8.0.0, v8.1.0 May 5, 2026

neutrinoceros changed the title ~~BLD: require extension-helpers 1.2.0 and simplify path type casting (⏰ wait for #16936)~~ BLD: require extension-helpers 1.2.0 and simplify path type casting Sep 11, 2026

neutrinoceros force-pushed the wcs/bld/bump_extension_helpers branch from 8b4fc9f to 7122049 Compare September 11, 2026 13:54

neutrinoceros changed the title ~~BLD: require extension-helpers 1.2.0 and simplify path type casting~~ BLD/RFC: simplify path type casting in wcs/setup_package.py Sep 11, 2026

neutrinoceros force-pushed the wcs/bld/bump_extension_helpers branch 2 times, most recently from 11570bd to bb0fc20 Compare September 11, 2026 13:59

BLD/RFC: simplify path type casting in wcs/setup_package.py

d050ad3

neutrinoceros force-pushed the wcs/bld/bump_extension_helpers branch from bb0fc20 to d050ad3 Compare September 11, 2026 14:09

neutrinoceros marked this pull request as ready for review September 11, 2026 14:45

neutrinoceros requested a review from mcara as a code owner September 11, 2026 14:45

astrofrog approved these changes Sep 11, 2026

View reviewed changes

mcara approved these changes Sep 11, 2026

View reviewed changes

pllim merged commit 987c678 into astropy:main Sep 11, 2026
43 of 45 checks passed

pllim removed the keep-open label Sep 11, 2026

neutrinoceros deleted the wcs/bld/bump_extension_helpers branch September 11, 2026 17:09

Conversation

neutrinoceros commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions Bot commented Oct 16, 2024

Uh oh!

github-actions Bot commented Oct 16, 2024

Uh oh!

mhvk left a comment

Choose a reason for hiding this comment

Uh oh!

mhvk Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

mhvk Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

mhvk Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

neutrinoceros commented Oct 17, 2024

Uh oh!

mhvk commented Oct 17, 2024

Uh oh!

neutrinoceros commented Oct 17, 2024

Uh oh!

github-actions Bot commented Mar 16, 2025

Uh oh!

astrofrog commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neutrinoceros commented Sep 11, 2026

Uh oh!

neutrinoceros commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

neutrinoceros commented Oct 16, 2024 •

edited

Loading

astrofrog commented Sep 11, 2026 •

edited

Loading

neutrinoceros commented Sep 11, 2026 •

edited

Loading