Skip to content

TST: fix a couple broken test cases - #17180

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:table/tst/fix_broken_test_cases
Oct 15, 2024
Merged

TST: fix a couple broken test cases#17180
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:table/tst/fix_broken_test_cases

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

I discovered while working on #17179 that a couple test cases were silently broken since #16433 when run against numpy>=2.0

This is admittedly confusing (which explains why I did this mistake and why it passed review), so let me try to explain what's going on:
Because of missing parens, these assert statements are currently equivalent to

assert (1 == 2 if condition else 1)

though the way the Python intepreter reads the expression (1 == 2 if False else True), it will first evaluate the condition (if condition) and then, with condition==False, jump to the else branch as the result of the expression: 1, which is "truthy", resulting in a successful assertion, never actually evaluating the (here, broken) comparison (1 == 2).
In short, the current form reads as

assert ((1 == 2) if condition else (1))

The correct, intended form is

assert 1 == (2 if condition else 1)
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v6.1.5 milestone Oct 15, 2024
@github-actions github-actions Bot added the table label Oct 15, 2024
@github-actions

github-actions Bot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros mentioned this pull request Oct 15, 2024
Closed
1 of 3 tasks
@neutrinoceros
neutrinoceros marked this pull request as ready for review October 15, 2024 10:17
pllim
pllim approved these changes Oct 15, 2024
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

p.s. If you milestone to backport branch release, then please also apply the backport label.

@pllim
pllim merged commit 7ad6509 into astropy:main Oct 15, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Oct 15, 2024
@pllim @meeseeksmachine
Backport PR astropy#17180: TST: fix a couple broken test cases
89987ef
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 15, 2024
Merged
@neutrinoceros
neutrinoceros deleted the table/tst/fix_broken_test_cases branch October 15, 2024 12:34
pllim added a commit that referenced this pull request Oct 15, 2024
@pllim
Merge pull request #17181 from meeseeksmachine/auto-backport-of-pr-17…
ee2d2c6 
…180-on-v6.1.x

Backport PR #17180 on branch v6.1.x (TST: fix a couple broken test cases)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes
@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner

Assignees

No one assigned

Labels

Bug no-changelog-entry-needed table testing

Projects

None yet

Milestone

v6.1.5

Development

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @pllim