Skip to content

cosmo: separate out tcmb - #17153

Merged
eerovaher merged 2 commits into
astropy:mainfrom
nstarman:cosmo-api-sep-tcmb
Dec 5, 2024
Merged

eerovaher merged 2 commits into
astropy:mainfrom
nstarman:cosmo-api-sep-tcmb

Conversation

@nstarman

@nstarman nstarman commented Oct 10, 2024 •

Copy link
Copy Markdown
Member

Part of #17150
Requires #17151

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@nstarman nstarman added this to the v7.0.0 milestone Oct 10, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman
nstarman force-pushed the cosmo-api-sep-tcmb branch 2 times, most recently from 900c5c9 to 7548973 Compare October 10, 2024 03:54
@pllim

pllim commented Oct 10, 2024

Copy link
Copy Markdown
Member

Feature freeze is fast impending. I doubt this is going to make it to v7.0 but we can move the milestone later.

@nstarman

Copy link
Copy Markdown
Member Author

If #17151 gets in, this PR is also very uncontroversial. There's no change to any public API.

@saimn saimn modified the milestones: v7.0.0, v7.1.0 Oct 26, 2024
Signed-off-by: nstarman <[email protected]>
@nstarman
nstarman marked this pull request as ready for review December 4, 2024 21:09
@nstarman
nstarman requested a review from a team as a code owner December 4, 2024 21:10
@nstarman
nstarman requested a review from eerovaher December 4, 2024 21:10

@eerovaher eerovaher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I should be reviewing #17150, but I can confirm that this pull request is analogous to #17151, which has already been merged, and it only concerns implementation details, not the public API.

@eerovaher
eerovaher merged commit 15346da into astropy:main Dec 5, 2024
@nstarman
nstarman deleted the cosmo-api-sep-tcmb branch December 5, 2024 18:25
@nstarman

nstarman commented Dec 5, 2024

Copy link
Copy Markdown
Member Author

Thanks @eerovaher. Would you be willing to continue reviewing such non-API changing PRs? These are the preliminary steps towards #17150, but as you point out, are non-cosmological.

@eerovaher

Copy link
Copy Markdown
Member

I don't know enough about cosmology to review the public API, but I suppose I can review refactoring implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants