Skip to content

TST: adapt a test to pytest<8 - #17143

Merged
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:units/hotfix/17141
Oct 9, 2024
Merged

mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:units/hotfix/17141

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #16892
Fixes #17141

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions Bot added the units label Oct 9, 2024
@github-actions

github-actions Bot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's probably the fastest solution to get things to pass again...

@mhvk mhvk added Bug Affects-dev PRs and issues that do not impact an existing Astropy release labels Oct 9, 2024
@mhvk mhvk added this to the v7.0.0 milestone Oct 9, 2024
@mhvk mhvk added Affects-dev PRs and issues that do not impact an existing Astropy release and removed Affects-dev PRs and issues that do not impact an existing Astropy release labels Oct 9, 2024
@mhvk
mhvk enabled auto-merge October 9, 2024 13:41
@mhvk
mhvk merged commit b6a3e21 into astropy:main Oct 9, 2024
@neutrinoceros
neutrinoceros deleted the units/hotfix/17141 branch October 9, 2024 13:46
@pllim

pllim commented Oct 9, 2024

Copy link
Copy Markdown
Member

Thanks! Should have run Extra CI though to be sure.

@pllim

pllim commented Oct 9, 2024

Copy link
Copy Markdown
Member

Kicked off a run here on main: https://github.com/astropy/astropy/actions/runs/11257102100

I'll bug you if the exotic archs don't pass. 😉

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

I'll bug you if the exotic archs don't pass.

please do !

@pllim

pllim commented Oct 9, 2024

Copy link
Copy Markdown
Member

They passed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_parse_strict_noncritical_error_default fails on 3/4 exotic archs with AssertionError: Regex pattern did not match

3 participants