Skip to content

TST: fixup to a test from #17130 - #17131

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/fixup_17130
Oct 7, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/fixup_17130

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Oct 6, 2024 •

Copy link
Copy Markdown
Contributor

Description

Hotfix for a mistake that slipped in from #17130

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot added the units label Oct 6, 2024
@pllim pllim added this to the v7.0.0 milestone Oct 7, 2024
@pllim pllim added Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed testing labels Oct 7, 2024

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. Thanks!

@pllim
pllim enabled auto-merge October 7, 2024 16:15
@pllim
pllim merged commit e8c7555 into astropy:main Oct 7, 2024
@neutrinoceros
neutrinoceros deleted the tst/fixup_17130 branch October 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed testing units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants