Skip to content

ENH: add support for NEP 35 array constructors (require, identiy, eye, tri, genfromtxt and loadtxt) with like=Quantity(...)) - #17130

Merged
mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:units/enh/impl_nep35_misc
Oct 6, 2024
Merged

mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:units/enh/impl_nep35_misc

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Concludes the first half of #17124 (units)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

… `eye`, `tri`, `genfromtxt` and `loadtxt`) with `like=Quantity(...))`
@neutrinoceros
neutrinoceros force-pushed the units/enh/impl_nep35_misc branch from b33c677 to 25cb626 Compare October 6, 2024 14:00
@neutrinoceros neutrinoceros mentioned this pull request Oct 6, 2024
6 of 28 tasks
@neutrinoceros
neutrinoceros force-pushed the units/enh/impl_nep35_misc branch 3 times, most recently from 7c69faf to 0eb53d4 Compare October 6, 2024 14:59
@neutrinoceros
neutrinoceros marked this pull request as ready for review October 6, 2024 15:15

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great to see this wrapped up! I'm not 100% sure we can fully support require (in particular "OWNDATA"), but to be honest, I'd never even heard about the function, so think it is sufficiently obscure not to worry... (Also, probably just a consequence of #7244.)

Comment thread docs/whatsnew/7.0.rst Outdated
<Quantity [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] m>
>>> np.eye(3, like=q)
<Quantity [[1., 0., 0.],
[0., 1., 0.],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment? Here and below

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Fixed !

@mhvk mhvk added this to the v7.0.0 milestone Oct 6, 2024
@neutrinoceros
neutrinoceros force-pushed the units/enh/impl_nep35_misc branch from 0eb53d4 to 78a915d Compare October 6, 2024 19:37

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the quick fix! Will set it to merge...

@mhvk
mhvk enabled auto-merge October 6, 2024 19:41
@mhvk
mhvk merged commit eb9ab35 into astropy:main Oct 6, 2024
@neutrinoceros
neutrinoceros deleted the units/enh/impl_nep35_misc branch October 6, 2024 19:54
neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Oct 6, 2024
@pllim pllim mentioned this pull request Oct 7, 2024
1 task
pllim added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants