Skip to content

Backport PR #17011 on branch v6.1.x (Recognize units written with unicode symbols also in composites) - #17091

Merged
pllim merged 1 commit into
astropy:v6.1.xfrom
mhvk:auto-backport-of-pr-17011-on-v6.1.x
Sep 30, 2024
Merged

Backport PR #17011 on branch v6.1.x (Recognize units written with unicode symbols also in composites)#17091
pllim merged 1 commit into
astropy:v6.1.xfrom
mhvk:auto-backport-of-pr-17011-on-v6.1.x

Conversation

@mhvk

@mhvk mhvk commented Sep 29, 2024 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

Recognize units written with unicode symbols also in composites

(cherry picked from commit 2611b0b)

Description

This pull request is to backport PR #17011 on branch v6.1.x

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@nstarman @mhvk
Merge pull request astropy#17011 from mhvk/units-composite-unicode
e8e86ef 
Recognize units written with unicode symbols also in composites

(cherry picked from commit 2611b0b)
@mhvk mhvk added this to the v6.1.5 milestone Sep 29, 2024
@github-actions

github-actions Bot commented Sep 29, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk added skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports labels Sep 29, 2024
pllim
pllim approved these changes Sep 30, 2024
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim

pllim commented Sep 30, 2024

Copy link
Copy Markdown
Member

close/reopen to make bot happy

@pllim pllim closed this Sep 30, 2024
@pllim pllim reopened this Sep 30, 2024
@pllim
pllim enabled auto-merge September 30, 2024 15:15
@pllim
pllim merged commit a3c26c3 into astropy:v6.1.x Sep 30, 2024
@mhvk
mhvk deleted the auto-backport-of-pr-17011-on-v6.1.x branch February 17, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Bug Manual Backport skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks units

Projects

None yet

Milestone

v6.1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mhvk @pllim @nstarman