Skip to content

TST: unignore numpy ABI compatibility warnings in tests - #17057

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/unignore_abi_compat_warnings
Sep 23, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/unignore_abi_compat_warnings

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

With the introduction of oldest-supported-numpy and the new backward-compatibility-by-default mechanism introduced in numpy 1.25, these warnings should be much less likely to occur in CI, and we might want to know when they do (this may still happen if we have an unmaintained optional dependency).
I'm taking a bet that they are currently not present in our CI jobs. Let's see what happens.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, looks like the bet has paid off!

@mhvk mhvk added this to the v7.0.0 milestone Sep 23, 2024
@neutrinoceros
neutrinoceros marked this pull request as ready for review September 23, 2024 14:19
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

🎉
I forgot to undraft this, thanks for the ping :)

@pllim pllim added Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Sep 23, 2024
@pllim

pllim commented Sep 23, 2024

Copy link
Copy Markdown
Member

Thanks! I will celebrate when all the optional jobs pass as well. 😉 🤞

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all green! Let's hope they don't creep back in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants