Skip to content

MNT: Run PTH flake test in prep for supporting pathlib (timeseries) - #16933

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:timeseries/rfc/pth_checks
Sep 5, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:timeseries/rfc/pth_checks

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Extracted from #16060. Ref #16924

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros marked this pull request as ready for review September 4, 2024 09:47
@pllim pllim added this to the v7.0.0 milestone Sep 4, 2024
@pllim pllim added no-changelog-entry-needed Extra CI Run cron CI as part of PR labels Sep 4, 2024
@pllim
pllim requested a review from astrofrog September 4, 2024 18:06
@neutrinoceros
neutrinoceros force-pushed the timeseries/rfc/pth_checks branch from 80d48dc to 3012545 Compare September 5, 2024 07:16
@pllim
pllim merged commit 21560b1 into astropy:main Sep 5, 2024
@neutrinoceros
neutrinoceros deleted the timeseries/rfc/pth_checks branch September 6, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants