Skip to content

ENH: improve support for Path objects in io.ascii.core.BaseInputter.get_lines - #16930

Merged
taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:io.ascii/enh/14893/improve_support_for_path_objects
Oct 25, 2024
Merged

taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:io.ascii/enh/14893/improve_support_for_path_objects

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 4, 2024 •

Copy link
Copy Markdown
Contributor

Description

Ref: #14893

This relieves a specific pain point I encountered while working on #16928, and participates to unblock it.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

TODO:

  • add a test

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the io.ascii/enh/14893/improve_support_for_path_objects branch from 4722435 to c5a7dcb Compare September 4, 2024 07:10
@neutrinoceros neutrinoceros changed the title ENH: improve support for Path objects in io.ascii.core.BaseInputter.get_lines ENH: improve support for Path objects in io.ascii.core.BaseInputter.get_lines Sep 4, 2024
@pllim pllim added this to the v7.0.0 milestone Sep 4, 2024
@neutrinoceros
neutrinoceros force-pushed the io.ascii/enh/14893/improve_support_for_path_objects branch from c5a7dcb to 1fe8042 Compare September 5, 2024 09:33
@neutrinoceros
neutrinoceros marked this pull request as ready for review September 5, 2024 09:34
Comment thread docs/changes/io.ascii/16930.feature.rst Resolved
@taldcroft

Copy link
Copy Markdown
Member

RTD is failing... presumably unrelated but I don't have the power to get around that.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

whoops. It is actually related

<unknown>:20: WARNING: py:obj reference target not found: io.ascii.core.BaseInputter.get_lines [ref.obj]

Let me try and fix the changelog fragment.

@neutrinoceros
neutrinoceros force-pushed the io.ascii/enh/14893/improve_support_for_path_objects branch from e70b6fd to e5fbfe7 Compare September 5, 2024 13:03
@pllim

pllim commented Sep 5, 2024

Copy link
Copy Markdown
Member

CI green now. @taldcroft do you want to re-review?

@neutrinoceros
neutrinoceros force-pushed the io.ascii/enh/14893/improve_support_for_path_objects branch from e5fbfe7 to 2cffa24 Compare September 6, 2024 06:34
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

@taldcroft or feel free to move this to 7.1

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

We're hours away from astropy 7.0's feature freeze and this shouldn't be blocking in any way, so I'll bump the milestone to clear the backlog. If this happened to be merged today anyway, please revert the milestone.

@neutrinoceros neutrinoceros modified the milestones: v7.0.0, v7.1.0 Oct 25, 2024

@dhomeier dhomeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note, otherwise this seems a useful improvement.

Comment thread astropy/io/ascii/core.py Resolved
@neutrinoceros
neutrinoceros force-pushed the io.ascii/enh/14893/improve_support_for_path_objects branch from 96bab41 to bacd246 Compare October 25, 2024 14:36

@dhomeier dhomeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; on my part this would be good to go for 7.0, but I think @taldcroft should have a final look for that.

@taldcroft
taldcroft merged commit f16c0b6 into astropy:main Oct 25, 2024
@neutrinoceros
neutrinoceros deleted the io.ascii/enh/14893/improve_support_for_path_objects branch October 25, 2024 15:51
@neutrinoceros neutrinoceros modified the milestones: v7.1.0, v7.0.0 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants