-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update IERS eopc04_IAU2000.62-now file for 0.3 release #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah, good idea! Assuming this passes it seems fine. |
|
travis passed (as it should!) -- this should be OK. |
|
Does it make sense to store it compressed? This will cause the whole file to be added to the repo every time it is changed, right? (500k each time?) What is it uncompressed? |
|
This should be 0.3 -- this is a file that should always be updated whenever a release happens (which I why I mentioned we need to automate it -- now made new issue about that). The iers file is 3 MB uncompressed, so 6 times larger, but of course only little bits of text get added over a year (since it covers everything since 1962, it increases by about 2% each year or ~100kB/yr). I now see your point that if we do this regularly, the developers at least soon loose any benefits we would have from compression, especially since git does store differences compressed. So, I changed it to uncompressed. |
|
@astrofrog @mhvk - I see the point of having git track the changes, and it may actually be more efficient anyway because of git's built-in compression. But our guidelines have said over a megabyte is too big... Remind me again if this is a temporary measure, @mhvk? That is, will we permanently keep this file around, or is it a placeholder until we get a better online download working? Also, @mhvk, can you rebase this to eliminate the commit with the gzipped version? Otherwise we needlessly store a 500k binary file in git that never actually gets used. |
|
Also, @mhvk - it looks like the error is due to a bug in |
|
@eteq - OK, rebased. Thanks also for pointing to the download issue -- I had to change the filename in the main The consensus from when IERS was introduced was that we should provide an up-to-date IERS file in the package, so that one can get UT1 for any time before the packaging time. The alternative would be that upon installation it downloads these files (or upon first use of UT1), which I think was considered too cumbersome and prone to breakage. We may want to revisit this... (I'll add it to #1697) |
|
Ah, right, ok. So we likely will have to change this in some form at every release. Then it definitely makes sense to use the uncompressed version. |
|
@eteq - as you said, this is causing an error with |
|
@mhvk - I think the underlying issue is that we don't run the remote-data tests in travis (#734)... I just put a commit in master to fix this because it's clearly a bug, so you can try rebasing against that. However, I think the fact that you reach that part of |
|
@eteq - there is something truly odd, perhaps related to the filename, in that |
|
@eteq - never mind - the problem is that the file does not actually get copied in building. |
|
Ah, you need to define it in |
|
e.g. |
|
@astrofrog, @eteq - thanks! I must have once done this (or someone else did it for me when implementing IERS), but I had clearly forgotten. It now builds OK.... (famous last words). |
|
Problem now seems just to be a very busy travis (timeouts in building)... |
|
Looks like everything's passing, so I'll just go ahead and merge. Thanks @mhvk |
Update IERS eopc04_IAU2000.62-now file for 0.3 release
To ensure UT1 can be calculated for dates up to ~Oct'13. Obviously, we'll need to automate this at some point...