Skip to content

MNT: Run PTH flake test in prep for supporting pathlib (cosmology) - #16925

Merged
nstarman merged 1 commit into
astropy:mainfrom
neutrinoceros:cosmology/rf/pth_checks
Sep 3, 2024
Merged

nstarman merged 1 commit into
astropy:mainfrom
neutrinoceros:cosmology/rf/pth_checks

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Extracted from #16060

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Parameters
----------
filename : str
filename : str | bytes | os.PathLike

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature that needs change log?

@nstarman nstarman Sep 3, 2024 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already checked for str | bytes | os.PathLike.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just a doc fix of existing feature?

@pllim

pllim commented Sep 3, 2024

Copy link
Copy Markdown
Member

@nstarman , if this does not need a change log after all, feel free to put the no-changelog-entry-needed label back and approve and merge. Thanks!

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neutrinoceros !

@nstarman

nstarman commented Sep 3, 2024

Copy link
Copy Markdown
Member

The pre-commit failures are real.

@neutrinoceros
neutrinoceros force-pushed the cosmology/rf/pth_checks branch from c641c32 to 3d9b483 Compare September 3, 2024 20:32
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

fixed

@nstarman
nstarman enabled auto-merge September 3, 2024 20:43
@nstarman
nstarman merged commit 1b563c2 into astropy:main Sep 3, 2024
@neutrinoceros
neutrinoceros deleted the cosmology/rf/pth_checks branch September 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants