Skip to content

Backport PR #16911 on branch main (Finalizing changelog for v6.1.3) - #16912

Merged
pllim merged 1 commit into
astropy:mainfrom
meeseeksmachine:auto-backport-of-pr-16911-on-main
Aug 30, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
meeseeksmachine:auto-backport-of-pr-16911-on-main

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #16911: Finalizing changelog for v6.1.3

@lumberbot-app lumberbot-app Bot added this to the v6.1.3 milestone Aug 30, 2024
@lumberbot-app lumberbot-app Bot added wcs table modeling utils skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports backport-main on-merge: backport to main labels Aug 30, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added Manual Backport and removed backport-main on-merge: backport to main labels Aug 30, 2024

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the labels a bit so it won't try to backport itself to main here. Thanks!

@pllim
pllim enabled auto-merge August 30, 2024 12:59
@pllim
pllim merged commit 27dfa87 into astropy:main Aug 30, 2024
@astrofrog

Copy link
Copy Markdown
Member

Interesting that the label does work here, it suggests the label is fine but it's maybe the fact the PRs aren't against main originally that mean the label doesn't work there?

@pllim

pllim commented Aug 30, 2024

Copy link
Copy Markdown
Member

I do suspect that but I did not dig at the bot code to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Manual Backport modeling skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks table utils wcs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants