Repository navigation
Simplify context manager for enabling units - #1662
Merged
Merged
Conversation
Member
|
Sounds good to me - looks like there's a minor whitespace warning in the docs? |
mhvk
added a commit
to mhvk/astropy
that referenced
this pull request
Oct 23, 2013
Contributor
Member
|
Yeah, assuming no one else has any problem this looks much better. |
Member
|
@mdboom - feel free to merge! |
mdboom
added a commit
that referenced
this pull request
Oct 24, 2013
Simplify context manager for enabling units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has always bugged me that we had separate functions for enabling
units permanently and temporarily. This merges
set_enabled_unitsand
set_enabled_units_contextinto a single function by using acustom context manager rather than
contextlib.contextmanager.It would be great to have this small change in 0.3, as it affects API.