Skip to content

MNT: remove temporary pin for bottleneck - #16584

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/remove_temp_bottleneck_pin
Jun 24, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/remove_temp_bottleneck_pin

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jun 18, 2024 •

Copy link
Copy Markdown
Contributor

Description

reverts part of #16579
Fixes #16574

This should be okay now that bottleneck 1.4.0 was released

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Docs failed due to an unrelated issue solved in #16583

@neutrinoceros
neutrinoceros marked this pull request as ready for review June 18, 2024 06:20
@neutrinoceros
neutrinoceros force-pushed the mnt/remove_temp_bottleneck_pin branch from a5b53be to 3e3f1d8 Compare June 18, 2024 18:02
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

rebased for docs

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
pllim merged commit 6201857 into astropy:main Jun 24, 2024
@lumberbot-app

This comment was marked as resolved.

@pllim

pllim commented Jun 24, 2024

Copy link
Copy Markdown
Member

Never mind. Looks like this was never backported.

@neutrinoceros
neutrinoceros deleted the mnt/remove_temp_bottleneck_pin branch June 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: CI jobs with optional deps are broken due to lack of a stable version of bottleneck with numpy 2.0 compat

2 participants