Skip to content

Backport PR 16579 on branch v6.1.x (various adjustments following the release of numpy 2.0) - #16580

Merged
astrofrog merged 1 commit into
astropy:v6.1.xfrom
neutrinoceros:bp/16579
Jun 17, 2024
Merged

Backport PR 16579 on branch v6.1.x (various adjustments following the release of numpy 2.0)#16580
astrofrog merged 1 commit into
astropy:v6.1.xfrom
neutrinoceros:bp/16579

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Description

Manual and partial backport for #16579. I've explicitly excluded 4f45f53, and other changes that are not applicable (no-ops) to the backport branch.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@astrofrog @neutrinoceros
Merge pull request astropy#16579 from neutrinoceros/tst/adjustments_f…
7eb48c6 
…or_numpy_2.0

TST: various adjustments following the release of numpy 2.0
@github-actions

github-actions Bot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros mentioned this pull request Jun 17, 2024
Merged
1 task
@astrofrog astrofrog added Manual Backport skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports labels Jun 17, 2024
@astrofrog astrofrog added this to the v6.1.1 milestone Jun 17, 2024
astrofrog
astrofrog approved these changes Jun 17, 2024
View reviewed changes

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! RTD will need to be fixed in a separate PR.

@astrofrog
astrofrog merged commit a4beccb into astropy:v6.1.x Jun 17, 2024
@neutrinoceros neutrinoceros mentioned this pull request Jun 17, 2024
Merged
1 task
@neutrinoceros
neutrinoceros deleted the bp/16579 branch June 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees

No one assigned

Labels

installation Manual Backport skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks testing

Projects

None yet

Milestone

v6.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @astrofrog