Skip to content

TST: various adjustments following the release of numpy 2.0 - #16579

Merged
astrofrog merged 5 commits into
astropy:mainfrom
neutrinoceros:tst/adjustments_for_numpy_2.0
Jun 17, 2024
Merged

astrofrog merged 5 commits into
astropy:mainfrom
neutrinoceros:tst/adjustments_for_numpy_2.0

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jun 17, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR combines patches from #16571, #16572, #16573 and #16575, which together should get CI back to green

close #16512
close #16257
close #16571
close #16572
close #16573
close #16575

follow up issues:

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the tst/adjustments_for_numpy_2.0 branch from 96dfe7f to 556f0f9 Compare June 17, 2024 08:15
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

OK I think we're good. Since it's still pretty small and arguably focused on one task, I'll just close all PRs that are combined here for clarity.

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We need to make sure we backport this to v6.1.x so I can cut a v6.1.1 release.

@astrofrog astrofrog added this to the v6.1.1 milestone Jun 17, 2024
@astrofrog
astrofrog merged commit d5bd585 into astropy:main Jun 17, 2024
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

If you don't mind I think we should also discuss whether #16578 can be fixed within a short enough time that the solution can also be backported

@neutrinoceros
neutrinoceros deleted the tst/adjustments_for_numpy_2.0 branch June 17, 2024 08:43
@lumberbot-app

This comment was marked as resolved.

neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Jun 17, 2024
…or_numpy_2.0

TST: various adjustments following the release of numpy 2.0
neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Jun 17, 2024
…or_numpy_2.0

TST: various adjustments following the release of numpy 2.0
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Manual backport is at #16580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants