Skip to content

TST: use bottleneck release candidate for numpy 2.0 compat - #16575

Closed
neutrinoceros wants to merge 2 commits into
astropy:mainfrom
neutrinoceros:tst/bottleneck_pre
Closed

neutrinoceros wants to merge 2 commits into
astropy:mainfrom
neutrinoceros:tst/bottleneck_pre

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

alldeps jobs are currently failing due to bottleneck not yet having a compatible stable release.
This is a temporary workaround. #16574 is the reminder issue to revert it when possible.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Image tests with mpl 3.6.0 are still failing but the root cause is different. This other problem is fixed in #16573

@neutrinoceros

neutrinoceros commented Jun 16, 2024 •

Copy link
Copy Markdown
Contributor Author

4 other tests are currently failing on Windows with

AttributeError: attribute 'data' of 'numpy.ndarray' objects is not writable

I suspect it would be a bottleneck bug, but given the platform specificity it's still possible that it's really a numpy bug since we've only been testing for it on Linux. I don't have more time to dig into it just now but I can make it my priority in the morning.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Currently running experiments on my fork. I can already conclude that the problem isn't with bottleneck as not installing it at all doesn't fix the issue.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Actually I think the real problem was already known and linked : numpy/numpy#8628
What's changed is that this deprecation cycle was actually ended in numpy 2.0, but we didn't catch it before the final release because we didn't test on windows.
Since resolution is rather urgent but the solution doesn't appear trivial, I'll just propose to pin numpy < 2.0 on windows for now. I'll open a dedicated issue tommorow.
FYI @mhvk

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Superseded by #16579

@neutrinoceros
neutrinoceros deleted the tst/bottleneck_pre branch June 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant