Skip to content

TST: pin numpy<2 on image tests with oldest supported mpl - #16573

Closed
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/pin_numpy_on_mpl360
Closed

neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/pin_numpy_on_mpl360

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

This pull request is to address a surprise issue with numpy 2.0 (just released): matplotlib 3.6.0 didn't pin for it so we need to do it on our side

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Failures are unrelated. See #16574

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Superseded by #16579

@neutrinoceros
neutrinoceros deleted the tst/pin_numpy_on_mpl360 branch June 17, 2024 09:03
@pllim

pllim commented Jun 24, 2024

Copy link
Copy Markdown
Member

Wow... looks like I missed all the "fun" while on vacation. Thanks for taking care of the CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants