Skip to content

TST: improve test coverage for io.misc.yaml.AstropyDumper - #16444

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.misc/test/improve_coverage_float_repr
May 14, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.misc/test/improve_coverage_float_repr

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #16416
Fixes #16429

I tried testing these branches through the public interface (à la test_numpy_types) but pyyaml appears
to transform data along the way such that they were actually never reached, so I resorted to writing a test for implementation details.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v6.1.1 milestone May 13, 2024
@pllim pllim added testing Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed numpy-dev labels May 13, 2024
@pllim
pllim requested a review from taldcroft May 13, 2024 14:07
@neutrinoceros
neutrinoceros marked this pull request as ready for review May 13, 2024 15:19

@matteobachetti matteobachetti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. LGMT

@pllim
pllim enabled auto-merge May 14, 2024 13:05
@pllim
pllim disabled auto-merge May 14, 2024 13:07
@pllim
pllim merged commit d11e933 into astropy:main May 14, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 14, 2024
@neutrinoceros
neutrinoceros deleted the io.misc/test/improve_coverage_float_repr branch May 14, 2024 13:16
pllim added a commit that referenced this pull request May 14, 2024
…444-on-v6.1.x

Backport PR #16444 on branch v6.1.x (TST: improve test coverage for io.misc.yaml.AstropyDumper)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release io.misc no-changelog-entry-needed numpy-dev testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: Add test coverage to PR 16416 (BUG: fix yaml table serialization compatibility with numpy 2)

3 participants