Repository navigation
TST: improve test coverage for io.misc.yaml.AstropyDumper - #16444
Merged
pllim merged 1 commit intoMay 14, 2024
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
marked this pull request as ready for review
May 13, 2024 15:19
neutrinoceros
requested review from
WilliamJamieson and
matteobachetti
as code owners
May 13, 2024 15:19
matteobachetti
approved these changes
May 14, 2024
matteobachetti
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty straightforward. LGMT
pllim
enabled auto-merge
May 14, 2024 13:05
pllim
disabled auto-merge
May 14, 2024 13:07
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
May 14, 2024
…l.AstropyDumper
pllim
added a commit
that referenced
this pull request
May 14, 2024
…444-on-v6.1.x Backport PR #16444 on branch v6.1.x (TST: improve test coverage for io.misc.yaml.AstropyDumper)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #16416
Fixes #16429
I tried testing these branches through the public interface (à la
test_numpy_types) butpyyamlappearsto transform data along the way such that they were actually never reached, so I resorted to writing a test for implementation details.