Skip to content

BUG: fix bugs with how masked structured arrays were represented with numpy 2 - #16443

Merged
mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:utils/compat/16423/numpy2_scalar_repr
May 13, 2024
Merged

mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:utils/compat/16423/numpy2_scalar_repr

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

This pull request is to address part of #16423 (specifically, io.utils.masked).
The first commit is common with #16426, #16427, #16433 and #16442 (allowing them to be merged in arbitrary order).
The fix itself is cherry-picked from #15065

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the utils/compat/16423/numpy2_scalar_repr branch from 98d15a7 to ea868c2 Compare May 13, 2024 07:27
@neutrinoceros
neutrinoceros marked this pull request as ready for review May 13, 2024 09:39
@pllim
pllim requested a review from mhvk May 13, 2024 14:23
@pllim pllim added this to the v6.1.1 milestone May 13, 2024
@pllim

pllim commented May 13, 2024

Copy link
Copy Markdown
Member

Backport?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Yes please

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also great! I'll just merge this one so the others can rely on the first commit.

@mhvk
mhvk merged commit bd4a323 into astropy:main May 13, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 13, 2024
pllim added a commit that referenced this pull request May 13, 2024
…443-on-v6.1.x

Backport PR #16443 on branch v6.1.x (BUG: fix bugs with how masked structured arrays were represented with numpy 2)
@neutrinoceros
neutrinoceros deleted the utils/compat/16423/numpy2_scalar_repr branch May 14, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants