Repository navigation
BUG: fix bugs with how masked structured arrays were represented with numpy 2 - #16443
Merged
mhvk merged 2 commits intoMay 13, 2024
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
utils/compat/16423/numpy2_scalar_repr
branch
from
May 13, 2024 07:27
98d15a7 to
ea868c2
Compare
neutrinoceros
marked this pull request as ready for review
May 13, 2024 09:39
neutrinoceros
requested review from
WilliamJamieson and
matteobachetti
as code owners
May 13, 2024 09:39
Member
|
Backport? |
Contributor
Author
|
Yes please |
mhvk
approved these changes
May 13, 2024
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Also great! I'll just merge this one so the others can rely on the first commit.
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
May 13, 2024
…rrays were represented with numpy 2
pllim
added a commit
that referenced
this pull request
May 13, 2024
…443-on-v6.1.x Backport PR #16443 on branch v6.1.x (BUG: fix bugs with how masked structured arrays were represented with numpy 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address part of #16423 (specifically,
io.utils.masked).The first commit is common with #16426, #16427, #16433 and #16442 (allowing them to be merged in arbitrary order).
The fix itself is cherry-picked from #15065