Repository navigation
BUG: fix compatibility with numpy 2 in diff reports (io.fits, utils) - #16426
Merged
mhvk merged 2 commits intoMay 13, 2024
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
io.fits/compat/16423/numpy2_diff_reports
branch
from
May 9, 2024 16:16
be847ba to
06e84ba
Compare
This was referenced May 9, 2024
neutrinoceros
force-pushed
the
io.fits/compat/16423/numpy2_diff_reports
branch
2 times, most recently
from
May 9, 2024 16:50
6091d21 to
43d79e5
Compare
neutrinoceros
marked this pull request as ready for review
May 9, 2024 17:08
neutrinoceros
requested review from
WilliamJamieson,
matteobachetti and
saimn
as code owners
May 9, 2024 17:08
Member
|
Should this be backported? |
Contributor
Author
|
Yes |
1 task
neutrinoceros
force-pushed
the
io.fits/compat/16423/numpy2_diff_reports
branch
from
May 12, 2024 08:22
43d79e5 to
ad712d7
Compare
neutrinoceros
commented
May 12, 2024
Comment on lines
+1115
to
+1116
| # Convert to int to avoid np.int64 in list repr. | ||
| index = [int(x + 1) for x in reversed(index)] |
Member
There was a problem hiding this comment.
In that case, I pinged mhvk for review. Thanks!
Co-authored-by: Marten van Kerkwijk <[email protected]>
neutrinoceros
force-pushed
the
io.fits/compat/16423/numpy2_diff_reports
branch
from
May 12, 2024 09:27
ad712d7 to
07c8cb7
Compare
Contributor
Author
This was referenced May 13, 2024
Contributor
|
Ah, I see it is smart enough to recognize that the first commit is already in main and is not a problem. So, let's merge this one too. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
May 13, 2024
…f reports (io.fits, utils)
pllim
added a commit
that referenced
this pull request
May 13, 2024
…426-on-v6.1.x Backport PR #16426 on branch v6.1.x (BUG: fix compatibility with numpy 2 in diff reports (io.fits, utils))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address part of #16423 (specifically, failing tests from io.fits)