Repository navigation
BUG: fix writing a HDUList to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API) - #16384
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
marked this pull request as ready for review
May 5, 2024 07:47
astrofrog
approved these changes
May 5, 2024
… least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API)
neutrinoceros
force-pushed
the
io.fits/compat/dask_numpy2
branch
from
May 5, 2024 08:56
9b81578 to
8ad89f3
Compare
HDUList to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API)
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
May 6, 2024
…numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API)
pllim
added a commit
that referenced
this pull request
May 6, 2024
…384-on-v6.1.x Backport PR #16384 on branch v6.1.x (BUG: fix writing a `HDUList` to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API))
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should fix a new error we're seeing in daily cron (example logs).
I'm very much a newbie in dask so I'm not 100% sure the fix is correct but it's following the recommendation included in numpy's error message (embedded in dask's) and it gets tests passing locally.