Skip to content

BUG: fix writing a HDUList to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API) - #16384

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.fits/compat/dask_numpy2
May 6, 2024

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

This should fix a new error we're seeing in daily cron (example logs).
I'm very much a newbie in dask so I'm not 100% sure the fix is correct but it's following the recommendation included in numpy's error message (embedded in dask's) and it gets tests passing locally.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented May 5, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented May 5, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros marked this pull request as ready for review May 5, 2024 07:47
@neutrinoceros
neutrinoceros requested a review from saimn as a code owner May 5, 2024 07:47
… least some of

the data is represented as dask arrays (compatibility between numpy 2 and dask API)
@astrofrog astrofrog added this to the v6.1.1 milestone May 5, 2024
@neutrinoceros
neutrinoceros force-pushed the io.fits/compat/dask_numpy2 branch from 9b81578 to 8ad89f3 Compare May 5, 2024 08:56
@neutrinoceros neutrinoceros changed the title BUG: fix compatibility between numpy 2 and dask API BUG: fix writing a HDUList to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API) May 5, 2024
@pllim pllim added the Bug label May 6, 2024
@pllim
pllim merged commit 0edb215 into astropy:main May 6, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 6, 2024
…numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API)
@neutrinoceros
neutrinoceros deleted the io.fits/compat/dask_numpy2 branch May 6, 2024 13:58
pllim added a commit that referenced this pull request May 6, 2024
…384-on-v6.1.x

Backport PR #16384 on branch v6.1.x (BUG: fix writing a `HDUList` to file when numpy 2 is installed and at least some of the data is represented as dask arrays (compatibility between numpy 2 and dask API))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants