RFC: improve readability of IPython-specific code blocks#16369
Merged
pllim merged 1 commit intoastropy:mainfrom May 2, 2024
Merged
RFC: improve readability of IPython-specific code blocks#16369pllim merged 1 commit intoastropy:mainfrom
pllim merged 1 commit intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
1 task
8dad9e7 to
5ce261c
Compare
pllim
reviewed
May 2, 2024
astropy/tests/test_logger.py
Outdated
| ip = None | ||
| _WITHIN_IPYTHON = False | ||
| else: | ||
| _WITHIN_IPYTHON = True |
Member
There was a problem hiding this comment.
I think you can import _WITHIN_IPYTHON from logger.py instead of redefining it here?
5ce261c to
f94f7a0
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has come up in #16354 (comment) :
basically neither @pllim or I knew how these blocks worked off-hand and it caused some confusion, so I'm trying to rewrite the logic in a (hopefully) clearer fashion.