Repository navigation
DOC: rework documentation for the __astropy_table__ protocol to avoid mingling with numpy 2.0's copy semantics - #16239
Merged
taldcroft merged 1 commit intoMar 27, 2024
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
taldcroft
requested changes
Mar 26, 2024
| of the implementation. The implementation might choose to allow an additional | ||
| keyword argument (e.g., ``strict_copy`` which gets passed via ``**kwargs``) to | ||
| control the behavior in this case. | ||
| The ``copy`` argument should follow the conventions used by |Table| |
| raise ValueError(f'cannot have copy=False because column {name} is ' | ||
| 'not an ndarray') | ||
| if mask_invalid: | ||
| cols = [Masked(col, mask=np.isnan(col)) for col in cols] |
Member
There was a problem hiding this comment.
Even though this is a toy example, it seems like you should only make cols Masked if need be:
Suggested change
| cols = [Masked(col, mask=np.isnan(col)) for col in cols] | |
| cols = [ | |
| Masked(col, mask=mask) if np.any(mask := np.isnan(col)) else col | |
| for col in cols | |
| ] |
Contributor
Author
There was a problem hiding this comment.
good point, and love that walrus !
neutrinoceros
force-pushed
the
table/doc/update__astropy_table__16235
branch
2 times, most recently
from
March 26, 2024 14:25
07738d9 to
f666458
Compare
mhvk
reviewed
Mar 26, 2024
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good, just a further suggestion for shrinkage, and an indentation nitpick.
| of the implementation. The implementation might choose to allow an additional | ||
| keyword argument (e.g., ``strict_copy`` which gets passed via ``**kwargs``) to | ||
| control the behavior in this case. | ||
| The ``copy`` argument should follow the conventions used by |Table|. |
Contributor
There was a problem hiding this comment.
I think we should just delete the paragraph altogether (i.e., also delete 1251-1253 now). We already say copy is passed through, and have just mentioned that mask_invalid ends up in **kwargs.
Contributor
Author
There was a problem hiding this comment.
good call. Fixed
| raise ValueError(f'cannot have copy=False because column {name} is ' | ||
| 'not an ndarray') | ||
| if mask_invalid: | ||
| cols = [ |
… mingling with numpy 2.0's copy semantics
neutrinoceros
force-pushed
the
table/doc/update__astropy_table__16235
branch
from
March 27, 2024 06:03
f666458 to
1fe430c
Compare
d-giles
referenced
this pull request
in d-giles/astropy-abdufork
Jul 26, 2024
… mingling with numpy 2.0's copy semantics (#16239)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16235