Skip to content

Backport PR #16147 on branch v6.0.x (TST: temporarily pin pytest<8.1) - #16151

Closed
neutrinoceros wants to merge 1 commit into
astropy:v6.0.xfrom
neutrinoceros:bp/6.0.x/16147
Closed

neutrinoceros wants to merge 1 commit into
astropy:v6.0.xfrom
neutrinoceros:bp/6.0.x/16147

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Backport PR #16147 on branch v6.0.x

@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@MridulS

MridulS commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Just FYI, pytest 8.1 is yanked pytest-dev/pytest#12069 (comment) and I think the removals are punted to 9.x release.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Oh, then we probably don't need this backport, thanks for the update !

@neutrinoceros
neutrinoceros deleted the bp/6.0.x/16147 branch March 4, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants