Repository navigation
MAINT: Use array-api-strict instead of np.array_api - #16150
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Thanks ! I think we can just close #16148 in favor of this one |
|
Thanks! Let me run the "exotic archs" also, just in case. |
|
devdeps failure is unrelated (but also kinda bad because we want to test this on devdeps, right?) |
|
How important is it to wait for #16142 to get merged first and then rebase, so you can be sure this works with numpy-dev? |
|
If it helps, I just took out controversial parts from #16142 so it's more lightweight and hopefully backportable now :) |
mhvk
left a comment
There was a problem hiding this comment.
Looks good, thanks! I agree that we should keep the test, since this was added because of a specific issue. And adding the dependency to test_all seems just right.
|
Any new Array API changes are unlikely to be backported anyway, right? Is there a reason why this PR needs to be backported? |
|
OK. I'll let you decide when to merge. Thanks, all! |
|
Thanks, @MridulS! |
Description
This fixes #16149
I think we should just add this optional dependency (it's a light python package) instead of skipping the test all together. If we are moving towards an array api astropy future we would need to add this dependency soon enough :)