Skip to content

Backport PR #16144 on branch v6.0.x (BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*)) - #16145

Merged
pllim merged 1 commit into
astropy:v6.0.xfrom
neutrinoceros:bp/6.0.x/16144
Mar 4, 2024
Merged

pllim merged 1 commit into
astropy:v6.0.xfrom
neutrinoceros:bp/6.0.x/16144

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Backport PR #16144 on branch v6.0.x

…uncs

BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*)
@github-actions

github-actions Bot commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk

mhvk commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

Oops, sorry!

@mhvk mhvk added no-changelog-entry-needed numpy-dev skip-basebranch-check Skip base branch check for direct backports labels Mar 3, 2024
@mhvk mhvk added this to the v6.0.1 milestone Mar 3, 2024
@pllim pllim closed this Mar 4, 2024
@pllim pllim reopened this Mar 4, 2024
@pllim
pllim enabled auto-merge March 4, 2024 18:51
@pllim

pllim commented Mar 4, 2024

Copy link
Copy Markdown
Member

Thanks!

@pllim
pllim merged commit 8db7126 into astropy:v6.0.x Mar 4, 2024
@neutrinoceros
neutrinoceros deleted the bp/6.0.x/16144 branch March 4, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants