Repository navigation
BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*) - #16144
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
neutrinoceros
force-pushed
the
numpy2/new_str_ufuncs
branch
from
March 3, 2024 17:12
aec4161 to
5668fd3
Compare
mhvk
approved these changes
Mar 3, 2024
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This looks good. Note that there are more to come...
Contributor
Author
One byte at a time 😄 |
Contributor
|
I've merged this despite the |
Contributor
Author
neutrinoceros
pushed a commit
to neutrinoceros/astropy
that referenced
this pull request
Mar 3, 2024
…uncs BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*)
Member
|
Is there a follow-up issue for the current numpy-dev failure? Update: Ah, nvm, I see #16142 |
pllim
added a commit
that referenced
this pull request
Mar 4, 2024
Backport PR #16144 on branch v6.0.x (BUG: declare private str ufuncs as unsupported (`np._core.umath._expandtabs*`))
Contributor
Author
|
yeah, I naively thought the patch would be trivial so I didn't open an issue for it. Now that the situation is clearer, I'm planning to open a long term issue for what's next ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick follow up to #15699
xref numpy/numpy#25891