Skip to content

BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*) - #16144

Merged
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/new_str_ufuncs
Mar 3, 2024
Merged

mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/new_str_ufuncs

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Mar 3, 2024 •

Copy link
Copy Markdown
Contributor

Description

Quick follow up to #15699

xref numpy/numpy#25891

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions Bot added the units label Mar 3, 2024
@github-actions

github-actions Bot commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros force-pushed the numpy2/new_str_ufuncs branch from aec4161 to 5668fd3 Compare March 3, 2024 17:12

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good. Note that there are more to come...

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Note that there are more to come...

One byte at a time 😄

@mhvk
mhvk merged commit 5fe3e01 into astropy:main Mar 3, 2024
@mhvk

mhvk commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

I've merged this despite the-dev job not passing since this is quite obviously correct, and we know where the trouble is with -dev.

@neutrinoceros
neutrinoceros deleted the numpy2/new_str_ufuncs branch March 3, 2024 18:00
@neutrinoceros

neutrinoceros commented Mar 3, 2024 •

Copy link
Copy Markdown
Contributor Author

@mhvk I think you forgot the backport label. I'll do it manually.

update: #16145

neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Mar 3, 2024
…uncs

BUG: declare private str ufuncs as unsupported (np._core.umath._expandtabs*)
@pllim

pllim commented Mar 4, 2024 •

Copy link
Copy Markdown
Member

Is there a follow-up issue for the current numpy-dev failure?

astropy/units/quantity.py:829: in _new_view
    obj = np.array(obj, copy=False, subok=True)
E   ValueError: Unable to avoid copy while creating an array.

Update: Ah, nvm, I see #16142

pllim added a commit that referenced this pull request Mar 4, 2024
Backport PR #16144 on branch v6.0.x (BUG: declare private str ufuncs as unsupported (`np._core.umath._expandtabs*`))
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

yeah, I naively thought the patch would be trivial so I didn't open an issue for it. Now that the situation is clearer, I'm planning to open a long term issue for what's next !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants